mojo_csv #89
Open
mojo_csv #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added the test files here after reading some comments on another MR... setup to run after package is built, if i understood it correctly. |
|
Let me know whats required to fix this. The test file is in the recipe folder and the source repo, so the error doesn't make sense to me. |
|
Hi @Phelsong, can you try removing the quotation marks around the test invocation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).Csv lib, mostly rfc-4180 compliant while handling trailing commas.
https://www.rfc-editor.org/rfc/rfc4180
https://github.com/Phelsong/mojo_csv