Skip to content

fix(rspack): avoid falsy values in checkSingleton #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbroma
Copy link
Contributor

@jbroma jbroma commented Feb 5, 2025

Description

added a check for falsy values inside checkSingleton in packages/rspack/src/ModuleFederationPlugin.ts.

This is similar to other places in the codebase when looking for ModuleFederationPlugin instances, this specific change was based on the logic from packages/enhanced/src/lib/container/ContainerPlugin.ts

Related Issue

n/a

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: ea48919

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@module-federation/rspack Patch
@module-federation/enhanced Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
remote5 Patch
@module-federation/runtime Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/runtime-core Patch
create-module-federation Patch
@module-federation/cli Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit ea48919
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/680312eac205e60008b1a631
😎 Deploy Preview https://deploy-preview-3487--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbroma
Copy link
Contributor Author

jbroma commented Mar 3, 2025

@2heal1 can we get this merged?

@ScriptedAlchemy
Copy link
Member

Yes sorry, had some CI failures, let me see if it works now then ill merge this weekend

@jbroma
Copy link
Contributor Author

jbroma commented Apr 18, 2025

bumping this for visibility - anything stopping us from merging this?

@ScriptedAlchemy ScriptedAlchemy merged commit f323928 into module-federation:main Apr 23, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants