-
-
Notifications
You must be signed in to change notification settings - Fork 300
fix(rspack): avoid falsy values in checkSingleton
#3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rspack): avoid falsy values in checkSingleton
#3487
Conversation
🦋 Changeset detectedLatest commit: ea48919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@2heal1 can we get this merged? |
Yes sorry, had some CI failures, let me see if it works now then ill merge this weekend |
bumping this for visibility - anything stopping us from merging this? |
f323928
into
module-federation:main
Description
added a check for falsy values inside
checkSingleton
inpackages/rspack/src/ModuleFederationPlugin.ts
.This is similar to other places in the codebase when looking for
ModuleFederationPlugin
instances, this specific change was based on the logic frompackages/enhanced/src/lib/container/ContainerPlugin.ts
Related Issue
n/a
Types of changes
Checklist