-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(bridge-react): add support for custom createRoot on createBridgeComponent #3544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7479ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fa9ac44
to
80912a6
Compare
80912a6
to
48b2308
Compare
@radualex Thank you for your PR! |
@radualex I think we have provided the custom |
@radualex But also, I think supporting custom |
I think I identified the CI failure in this PR. Seems the issue is caused by an .only modifier in Verification steps: This should resolve the CI error blocking this PR. |
fix: remove .only modifier from test to fix CI
Description
Extended the definition of
createBridgeComponent
method to support an optional customcreateRoot
property that can overwrite the defaultcreateRoot
method. This can be used in the client app to load a custom React DOM for example:Related Issue
Fixes #3537
Types of changes
Checklist