Skip to content

chore(utils): add react 19 to peer dependencies#3630

Closed
cheesestringer wants to merge 2 commits intomodule-federation:mainfrom
cheesestringer:patch
Closed

chore(utils): add react 19 to peer dependencies#3630
cheesestringer wants to merge 2 commits intomodule-federation:mainfrom
cheesestringer:patch

Conversation

@cheesestringer
Copy link
Copy Markdown
Contributor

Description

Add react 19 to the optional peer dependencies for the utilities package and run pnpm i.
Removes some warning noise when using react 19.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 26bef9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 25, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 26bef9b
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67e64dc78d2eeb0008b027d7
😎 Deploy Preview https://deploy-preview-3630--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy
Copy link
Copy Markdown
Member

the utilities package is dead, you should not be using it at all. You should be using module-federation/runtime

@cheesestringer
Copy link
Copy Markdown
Contributor Author

Looks like utilities is a dependency in the node package https://github.com/module-federation/core/blob/main/packages/node/package.json#L72 which causes the warning to show up. Should I close this one and create a new PR to look at removing the dependency?

@ScriptedAlchemy
Copy link
Copy Markdown
Member

Yes please. I don't believe anything should be using that anymore.

@cheesestringer
Copy link
Copy Markdown
Contributor Author

Closing in favor of #3646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants