-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix: remove chunks from installedChunks on fail to enable retries #3686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove chunks from installedChunks on fail to enable retries #3686
Conversation
🦋 Changeset detectedLatest commit: b48ef9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5742a4b
to
e421d96
Compare
Should you not still reject the promise after deleting the chunk? |
Thanks for finding this tho - i think this is exactly what id need to do to also improve the 'hot reload' in the future as well |
It does still reject, I made it so that |
ok perfect. |
when will it be released? |
use this release in the meantime, the canary will have it the feature. |
Description
This CR resolves an issue I have been researching with our next.js MF implementation. Simply put, we have been experiencing temporary outages which only occur on prod after starting a new container, or MFE revalidation where
loadRemote
is unable to fetch a remote MFE - the issue is sporadic and not reproducible locally, it occurs when one or more chunk files fail to download.Related Issue
#3685
Types of changes
Checklist