Skip to content

fix(stage-ui): apply display model on character card activation#2090

Open
0xSelenicDove wants to merge 1 commit into
moeru-ai:mainfrom
0xSelenicDove:codex/fix-character-card-model-activation
Open

fix(stage-ui): apply display model on character card activation#2090
0xSelenicDove wants to merge 1 commit into
moeru-ai:mainfrom
0xSelenicDove:codex/fix-character-card-model-activation

Conversation

@0xSelenicDove

Copy link
Copy Markdown
Contributor

Summary

Fixes #2089

Validation

  • pnpm typecheck
  • pnpm lint (0 errors; existing warnings remain)
  • pnpm -F @proj-airi/stage-ui typecheck
  • pnpm exec eslint packages/stage-ui/src/stores/modules/airi-card.ts packages/stage-ui/src/stores/modules/airi-card.test.ts
  • focused Vitest: 4 tests passed; Node reports the existing localforage storage warning in this environment

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42acc046cb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/stage-ui/src/stores/modules/airi-card.ts Outdated
@0xSelenicDove
0xSelenicDove force-pushed the codex/fix-character-card-model-activation branch from 303f1c1 to 2491acc Compare July 19, 2026 15:07
@0xSelenicDove

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback in commit 2491acc7f. The synchronization now watches both activeCardId and the active card object, so switching cards and saving edits to the currently active card both update the runtime model/provider settings. Added regression coverage for active-card edits; the review thread is resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2491acc7f9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/stage-ui/src/stores/modules/airi-card.ts
@0xSelenicDove
0xSelenicDove force-pushed the codex/fix-character-card-model-activation branch from 2491acc to 2fc177d Compare July 19, 2026 15:18
@0xSelenicDove

Copy link
Copy Markdown
Contributor Author

Addressed the reset-ordering feedback in commit 2fc177d60. Card data is now cleared before activeCardId, preventing the synchronous watcher from reapplying the old default card model during a full settings reset. Added a regression test. Also mocked the browser-only localforage boundary in the Node unit test; the focused suite now passes 6/6 without unhandled errors.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fc177d60c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/stage-pages/src/pages/settings/data/components/chats-section.vue Outdated
@0xSelenicDove
0xSelenicDove force-pushed the codex/fix-character-card-model-activation branch from 2fc177d to 47a55e7 Compare July 19, 2026 15:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47a55e77b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/stage-pages/src/pages/settings/data/components/chats-section.vue Outdated
@0xSelenicDove
0xSelenicDove force-pushed the codex/fix-character-card-model-activation branch from 47a55e7 to 83975f1 Compare July 19, 2026 15:35
@0xSelenicDove

Copy link
Copy Markdown
Contributor Author

Rebuilt this PR from origin/main to keep it scoped to character-card/model synchronization. The inherited chat-import commit and all chat-related files have been removed from this PR. It now contains only airi-card.ts and airi-card.test.ts; the chat-import work remains separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix character card activation not applying its display model

1 participant