Conversation
src/core/event.js
Outdated
There was a problem hiding this comment.
So, open question (including @bklang): how do we treat users who aren't in our roster? Do we pass through the JID instead of a Contact, or do we pass something API-compatible with Contact but which nevertheless indicates absence of full details from the roster and is scoped only to this event?
There was a problem hiding this comment.
I am inclined to think something API-compatible with a Contact, but with the missing fields returning nil/undefined or empty strings. May also add a boolean for "in roster?"
malakada
force-pushed
the
feature/triggerhandler_candy_core_chat_invite
branch
from
b01d6f9 to
55ae884
Compare
There was a problem hiding this comment.
The item here comes directly from a callback on Candy.Core.getConnection().roster, so I'm making an assumption that if it's coming all the way to _addRosterItem() that it's for someone who can be safely said to be in our roster. It can get here either through it's sibling _addRosterItems() or through a direct callback created in Candy.Core.Action.Jabber.Roster().
malakada
force-pushed
the
feature/triggerhandler_candy_core_chat_invite
branch
from
55ae884 to
3d9ee4a
Compare
src/core/event.js
Outdated
There was a problem hiding this comment.
Why would we modify a contact's JID?
There was a problem hiding this comment.
In this case, because it's empty. It's being set above as a blank new Candy.Core.Contact and that data isn't set. Because there are two paths here, --oh. Hi. I meant to remove this line when I gave up on trying to consolidate it into one place before the if's and just put them in separately. Thanks. :)
|
Our only plugin that uses |
3 participants
This trigger isn't referenced anywhere else inside of Candy Core.