Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reclassify Cholelithiasis terms #8851

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

reclassify Cholelithiasis terms #8851

wants to merge 10 commits into from

Conversation

nicolevasilevsky
Copy link
Member

address #8630

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR.
@nicolevasilevsky if you have other source for the SC (so that it's not only an ORCID), please add it. If you cannot easily find one, it's ok. You can merge the PR.

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Mar 18, 2025

@sabrinatoro I made some major changes, can you please review this again?
see: #8630 (comment)

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not the correct strategy.
This PR is completely changing the concept of MONDO:0012672. AND we are recreating the concept in a new term.

Instead, we should update the current MONDO:0012672 and maintain the concept. The new term to be created should be for "gallbladder disease 4"

We can discuss this on the curation call if needed.

@nicolevasilevsky
Copy link
Member Author

we discussed this on a call - I will redo this per Sabrina's comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants