Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add term: name: BMP4-related ocular growth disorder #8859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add term: name: BMP4-related ocular growth disorder #8859

wants to merge 1 commit into from

Conversation

nicolevasilevsky
Copy link
Member

@nicolevasilevsky nicolevasilevsky commented Mar 16, 2025 •
edited by sabrinatoro
Loading

close #8786

@sabrinatoro
Copy link
Collaborator

@nicolevasilevsky I am pretty sure you meant "issue 8786" and not "issue 8486".
I updated the description of this PR.

@nicolevasilevsky
Copy link
Member Author

I probably misread it, I need reading glasses! 😆 Thanks for updating that

sabrinatoro
sabrinatoro requested changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky please see my comment.
If the definition and/or name include "ocular growth disorder", we need to define what it is.

src/ontology/mondo-edit.obo
[Term]
id: MONDO:0100613
name: BMP4-related ocular growth disorder
def: "Any ocular growth disorder in which the cause of the disease is a mutation in the BMP4 gene." [https://clinicalgenome.org/affiliation/40077/]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is missing.
if "ocular growth disorder" is in the name and/or the definition, we need to have "ocular growth disorder" defined.
We don't have a term for this, and it is not explained in the current definition.

This might require input from the requester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrinatoro sabrinatoro sabrinatoro requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nicolevasilevsky nicolevasilevsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR/gene] BMP4-related ocular growth disorder
2 participants
@nicolevasilevsky @sabrinatoro