fix(compass): manually set the keychain on linux to try to work around electron automatic keychain detection issues #5958
Conversation
| private static setupJavaScriptArguments(): void { | ||
| // For Linux users with drivers that are avoided by Chromium we disable the | ||
| // GPU check to attempt to bypass the disabled WebGL settings. | ||
| app.commandLine.appendSwitch('ignore-gpu-blacklist', 'true'); |
There was a problem hiding this comment.
Feels like it's something we want to set as early as possible, for consistency moved this and the new appendSwitch call to the setup-* file that is the first thing that runs in the app
| * @see {@link https://github.com/microsoft/vscode/issues/185212#issuecomment-1593271415} | ||
| */ | ||
| if (app.commandLine.hasSwitch('password-store') === false) { | ||
| app.commandLine.appendSwitch('password-store', 'gnome-libsecret'); |
There was a problem hiding this comment.
Are there any other factors we should be taking into account when setting this default, e.g. specific values of $XDG_CURRENT_DESKTOP or whether the gnome-keyring binary is in PATH/whether a libsecret.so is available on the current system (I think a relatively easy way to check the latter would be to see which error gets thrown by process.dlopen({exports: {}}, 'libsecret-1.so.0'))?
There was a problem hiding this comment.
That's a good point! I was thinking about checking that XDG_ var is not in the "supported" list, but it seemed like a mess to maintain. I like the idea of checking for libsecret!
One thing I want to do first is to check what exactly happens when you set this in the environment where it's not supported. If it's not different from not setting it at all I think, just from the perspective of having less logic to maintain, I would prefer not to do any extra checks, but please tell me if this doesn't sound right to you 🙂
| const isLibsecretInstalled = () => { | ||
| try { | ||
| process.dlopen({ exports: {} }, 'libsecret-1.so.0'); | ||
| return true; | ||
| } catch (err: any) { | ||
| return err && err.message?.includes('did not self-register'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Totally forgot about this PR, @addaleax does this check looks good to you? The error codes between not installed and failed to open look the same, so I'm checking for the error message here, not sure if there's a better way to do it?
There was a problem hiding this comment.
Yeah, I don't think there's a better way right now 😕
gribnoysup
force-pushed
the
force-gnome-libsecrent-on-linux
branch
from
99b3f45 to
bc40d52
Compare
| const isLibsecretInstalled = () => { | ||
| try { | ||
| process.dlopen({ exports: {} }, 'libsecret-1.so.0'); | ||
| return true; | ||
| } catch (err: any) { | ||
| return err && err.message?.includes('did not self-register'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Yeah, I don't think there's a better way right now 😕
gribnoysup
added
the
no-title-validation
gribnoysup
changed the title
No idea if this is a bad idea to do so, but as we have gnome-keyring in the dependencies for all linux installers, maybe we can force the password store to work around the autodetection logic that causes issues to the users. Probably would not make it worse?