-
Notifications
You must be signed in to change notification settings - Fork 219
feat: lastModified and db for diagram list COMPASS-9398 #6951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paula-stacho
wants to merge
11
commits into
main
Choose a base branch
from
COMPASS-9398
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+266
−56
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b17b398
feat: lastModified and db for diagram list COMPASS-9398
paula-stacho 4ea9ed5
test: add tests
paula-stacho ea0aa6b
better types
paula-stacho 858bc99
trying to get it working
paula-stacho 5f8e99e
tests
paula-stacho d8c852d
help needed
paula-stacho 49a6f0e
extra overloads
paula-stacho c28f3d8
cleanup
paula-stacho c605022
cleanup
paula-stacho 95f2333
type edits as a non empty array
paula-stacho 50d0369
store last modified at diagram level
paula-stacho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
packages/compass-data-modeling/src/components/diagram-card.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
import React from 'react'; | ||
import { expect } from 'chai'; | ||
import { render, screen } from '@mongodb-js/testing-library-compass'; | ||
import { DiagramCard } from './diagram-card'; | ||
import type { Edit } from '../services/data-model-storage'; | ||
|
||
describe('DiagramCard', () => { | ||
const props = { | ||
diagram: { | ||
id: 'test-diagram', | ||
connectionId: 'test-connection', | ||
name: 'Test Diagram', | ||
createdAt: '2023-10-01T00:00:00.000Z', | ||
updatedAt: '2023-10-03T00:00:00.000Z', | ||
edits: [ | ||
{ | ||
id: 'edit-id', | ||
timestamp: '2023-10-01T00:00:00.000Z', | ||
type: 'SetModel', | ||
model: { | ||
collections: [ | ||
{ | ||
ns: 'db.collection', | ||
indexes: [], | ||
displayPosition: [0, 0], | ||
shardKey: {}, | ||
jsonSchema: { bsonType: 'object' }, | ||
}, | ||
], | ||
relationships: [], | ||
}, | ||
}, | ||
] as [Edit], | ||
databases: 'someDatabase', | ||
}, | ||
onOpen: () => {}, | ||
onDelete: () => {}, | ||
onRename: () => {}, | ||
}; | ||
|
||
it('renders name, database, last edited', () => { | ||
render(<DiagramCard {...props} />); | ||
expect(screen.getByText('Test Diagram')).to.be.visible; | ||
expect(screen.getByText('someDatabase')).to.be.visible; | ||
expect(screen.getByText('Last modified: October 3, 2023')).to.be.visible; | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.