Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: core telemetry functionality #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: core telemetry functionality #87
Changes from 32 commits
9cf0447
1b8ea02
af714b4
40aaef0
8adc20d
cff01e0
5336e4a
76e2a6f
1850676
3a5d4c1
23fff05
754ce8d
8301e43
994b698
3bfc9f2
6d92021
7997c54
f18b916
a9cd835
6813518
65fad1d
7e98c33
5209073
2e33584
d92adf1
8ec7d9c
6ad2a19
807109d
f9a46f9
599201d
7a889b4
eb360e2
710b131
a15eeb6
90caa25
89113a5
143f898
f751a30
0927d28
fb0b8af
9e625aa
a61d9b4
2bd00cf
3636fde
0df870c
4b7563d
6dd1f79
807b2ca
139c3ee
3a05d31
8505d91
024a3d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this to
MACHINE_METADATA
and maybe get rid of individual global constantsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it in the client though, so wanted to keep it here where is common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit confusing for me as it is inside a configuration, which to me means it is configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems constant, do we need this? maybe we add useragent instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need it for telemetry right? we could give user agent, but i figure that having the data split is better.. no strong opinion as we hope not to change server_name, but we might change after public preview