Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - chore(deps): add test for $lookup with field level encryption COMPASS-8816 #2427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Apr 4, 2025

It has previously been not possible to use $lookup stage of a pipeline with automatic encryption attached to it. This adds a test to verify it is possible along with another dependency bump.

@gagik gagik force-pushed the gagik/update-mongo-crypt branch from 623b4fa to 68affa2 Compare April 4, 2025 08:33
@@ -59,7 +59,7 @@
},
"optionalDependencies": {
"kerberos": "2.1.0",
"mongodb-client-encryption": "^6.1.1"
"mongodb-client-encryption": "^6.3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like mongodb-client-encryption was previously bumped but this package was left at the old version; was this intentional?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think that's just an oversight (or maybe a bad merge conflict resolve?) 👍

@gagik gagik force-pushed the gagik/update-mongo-crypt branch from 68affa2 to 28a4945 Compare April 4, 2025 08:36
@addaleax
Copy link
Collaborator

addaleax commented Apr 4, 2025

Just quoting myself from the ticket:

We will still want to add at least a mongosh e2e test on top of those, and we'll need to bump the crypt_shared library to 8.1 in both Compass and mongosh (for arm64/x64).

This should probably be an e2e test since we don't have the infrastructure for integration tests with the crypt_shared library in place in the shell-api package, and all similar tests are also e2e tests.

And, well, we need the 8.1 crypt_shared library, and that's not released yet.

@gagik gagik force-pushed the gagik/update-mongo-crypt branch from 28a4945 to a9a00c2 Compare April 4, 2025 10:32
@gagik gagik force-pushed the gagik/update-mongo-crypt branch from a9a00c2 to d6a3394 Compare April 4, 2025 10:33
@gagik gagik marked this pull request as draft April 4, 2025 10:33
@gagik gagik changed the title chore(deps): add test for $lookup with field level encryption COMPASS-8816 WIP - chore(deps): add test for $lookup with field level encryption COMPASS-8816 Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants