chore(telemetry): track view format VSCODE-783#1313
Open
Anemy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry dimensions to capture the configured document view/edit format (shell vs ejson) when users open/edit/save documents and when the data browser is opened.
Changes:
- Add
view_formatto multiple telemetry events (Document Edited,Document Updated,Data Browser Opened,Data Browser Document Edited) and thread it through call sites. - Update unit tests to assert the new
view_formatproperty is emitted. - Minor test typing tweak in
connectionControllertests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/dataBrowsingController.ts | Include view_format when tracking data browser open/edit events. |
| src/telemetry/telemetryEvents.ts | Extend telemetry event schemas/constructors to include view_format. |
| src/mdbExtensionController.ts | Pass document format into DocumentEditedTelemetryEvent. |
| src/editors/mongoDBDocumentService.ts | Include view_format in document save telemetry events. |
| src/test/suite/views/dataBrowsingController.test.ts | Assert view_format is present for data browser “edit document” telemetry. |
| src/test/suite/telemetry/telemetryService.test.ts | Update telemetry service tests for new event parameters/properties. |
| src/test/suite/connectionController.test.ts | Remove unnecessary cast in warning message assertion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCODE-783
It will be nice to see who is using this. I'm thinking likely nobody. Maybe we remove the setting altogether.