Skip to content

chore(telemetry): track view format VSCODE-783#1313

Open
Anemy wants to merge 2 commits into
mainfrom
VSCODE-783-add-telemetry-for-shell-vs-ejson
Open

chore(telemetry): track view format VSCODE-783#1313
Anemy wants to merge 2 commits into
mainfrom
VSCODE-783-add-telemetry-for-shell-vs-ejson

Conversation

@Anemy

@Anemy Anemy commented Jun 9, 2026

Copy link
Copy Markdown
Member

VSCODE-783

It will be nice to see who is using this. I'm thinking likely nobody. Maybe we remove the setting altogether.

Copilot AI review requested due to automatic review settings June 9, 2026 14:16
@Anemy Anemy requested a review from a team as a code owner June 9, 2026 14:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds telemetry dimensions to capture the configured document view/edit format (shell vs ejson) when users open/edit/save documents and when the data browser is opened.

Changes:

  • Add view_format to multiple telemetry events (Document Edited, Document Updated, Data Browser Opened, Data Browser Document Edited) and thread it through call sites.
  • Update unit tests to assert the new view_format property is emitted.
  • Minor test typing tweak in connectionController tests.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/views/dataBrowsingController.ts Include view_format when tracking data browser open/edit events.
src/telemetry/telemetryEvents.ts Extend telemetry event schemas/constructors to include view_format.
src/mdbExtensionController.ts Pass document format into DocumentEditedTelemetryEvent.
src/editors/mongoDBDocumentService.ts Include view_format in document save telemetry events.
src/test/suite/views/dataBrowsingController.test.ts Assert view_format is present for data browser “edit document” telemetry.
src/test/suite/telemetry/telemetryService.test.ts Update telemetry service tests for new event parameters/properties.
src/test/suite/connectionController.test.ts Remove unnecessary cast in warning message assertion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/dataBrowsingController.ts Outdated
Comment thread src/editors/mongoDBDocumentService.ts
Comment thread src/editors/mongoDBDocumentService.ts
Comment thread src/telemetry/telemetryEvents.ts
Comment thread src/telemetry/telemetryEvents.ts
Comment thread src/test/suite/views/dataBrowsingController.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants