Allow querying an EmbeddedModelField by model instance #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
emf-model-lookup
branch
3 times, most recently
from
d184b56 to
4900675
Compare
WaVEV
reviewed
Mar 12, 2025
WaVEV
reviewed
Mar 12, 2025
WaVEV
reviewed
Mar 13, 2025
WaVEV
approved these changes
Mar 13, 2025
WaVEV
reviewed
Apr 27, 2025
timgraham
force-pushed
the
emf-model-lookup
branch
3 times, most recently
from
3f9288e to
c0eb832
Compare
timgraham
force-pushed
the
emf-model-lookup
branch
from
c0eb832 to
5e31693
Compare
timgraham
force-pushed
the
emf-model-lookup
branch
from
5e31693 to
59e32d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature may not be merged since it's not a best practice to query this way. It may also be not intuitive that unlike SQL, querying by model doesn't necessary return a unique result since the embedded document match is field by field rather than by primary key.