Replace DatabaseWrapper.__getattr__() with a simpler database attribute #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I contemplated removing the self.database assignment from DatabaseWrapper.init_connection_state() which would have broken this.
Jibola
approved these changes
Apr 14, 2025
Comment on lines
+35
to
+36
| connection_created.connect(receiver) | ||
| connection.close() |
There was a problem hiding this comment.
Can we also assert that data is empty after calling close() or is that not necessary?
There was a problem hiding this comment.
Certainly could, but if close() actually created a connection (thus firing the connection_created signal) instead of closing, I think there would be other rather obvious problems.
Comment on lines
-157
to
-158
| return getattr(self, attr) | ||
| raise AttributeError(attr) |
There was a problem hiding this comment.
So we now won't raise an error if something other than database is
There was a problem hiding this comment.
The default implementation of __getattr__() raises AttributeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.