DOCSP-43125 - Remove SDAM Logging method #231
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/upgrade.txt
Outdated
| @@ -66,6 +66,11 @@ Version 3.0 Potential Breaking Change | |||
| configuring authentication in the {+driver-short+}, see | |||
| :ref:`Authentication Mechanisms. <csharp-authentication-mechanisms>` | |||
|
|
|||
| - This version removes the ``ClusterBuilder.ConfigureSdamLogging()`` method. | |||
| To configure SDAM logging, | |||
There was a problem hiding this comment.
It might sound that the new configuration is specific for SDAM.
Maybe it should be "SDAM or any other component" and point to our logging page https://www.mongodb.com/docs/drivers/csharp/current/fundamentals/logging/?
There was a problem hiding this comment.
When would you use MongoClientSettings.LoggingSettings vs. ClusterBuilder.ConfigureLoggingSettings? It looks like they both take an instance of LoggingSettings.
There was a problem hiding this comment.
ClusterBuilder is an internal component. Users shouldn't be using it.
There was a problem hiding this comment.
Exactly, some more context:
Unfortunately it is still a public API, and we've been recommending configuring SDAM logging before we had a proper logging mechanism.
So we still need to mention this potentially breaking change and point to our regular logging.
source/upgrade.txt
Outdated
| @@ -66,6 +66,11 @@ Version 3.0 Potential Breaking Change | |||
| configuring authentication in the {+driver-short+}, see | |||
| :ref:`Authentication Mechanisms. <csharp-authentication-mechanisms>` | |||
|
|
|||
| - This version removes the ``ClusterBuilder.ConfigureSdamLogging()`` method. | |||
| To configure SDAM logging, | |||
There was a problem hiding this comment.
ClusterBuilder is an internal component. Users shouldn't be using it.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43125
Staging Links
Self-Review Checklist