Skip to content

DOCSP-43419 - GuidRepresentationMode #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2024
Merged

DOCSP-43419 - GuidRepresentationMode #235

merged 6 commits into from
Sep 25, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 20, 2024 •
edited by github-actions bot
Loading

History of GUIDs adapted from PyMongo docs

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43419

Staging Links

  • fundamentals/serialization/guid-serialization
  • upgrade

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Sep 20, 2024 •
    edited
    Loading

    ✅ Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 4061a4d
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66f40e0750e1d30008878731
    😎 Deploy Preview https://deploy-preview-235--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    rustagir
    rustagir requested changes Sep 20, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    few things but good job addressing this confusing content

    @mongoKart mongoKart requested a review from rustagir September 21, 2024 15:32
    rustagir
    rustagir approved these changes Sep 23, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good work! left some answers, suggestions

    @mongoKart mongoKart requested a review from rstam September 23, 2024 14:53
    rstam
    rstam approved these changes Sep 24, 2024
    View reviewed changes
    Copy link
    Collaborator

    @rstam rstam left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    @mongoKart mongoKart merged commit d3c0037 into mongodb:v3.0 Sep 25, 2024
    2 checks passed
    @mongoKart mongoKart deleted the docsp-43419-guid-mode branch September 25, 2024 13:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rstam rstam rstam approved these changes

    @rustagir rustagir rustagir approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mongoKart @rstam @rustagir