-
Notifications
You must be signed in to change notification settings - Fork 24
v3 fast follows #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 fast follows #265
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification requested around removal of the legacy shim mongocsharpdriver
and the v2.x API deprecations.
source/upgrade/v3.txt
Outdated
|
||
- The v1.x legacy API, which was deprecated in v2, has been removed. If the driver | ||
provides a replacement for a deprecated API, the compiler | ||
messages in v2.x will display it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two separate issues here.
First the legacy v1.x API was removed. That was contained in the legacy shim mongocsharpdriver
. If you're using those v1.x APIs, you need to migrate to the new API and we don't provide any upgrade guidelines. Very few users are still on the old v1.x API and thus we don't provide upgrade guidance. (We don't need to say that. Just FYI.)
Second the v2.x API contained a number of deprecations, which have been removed in 3.0.0. The 2.30.0 driver contains guidance in the form of deprecation warnings including the new APIs to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the clarification. It was hard to find specifics about this. I moved the legacy shim removal from What's New to Breaking Changes (since it will be, for anyone still using it) and changed the wording.
I believe the following two entries in the Upgrade Guide adequately discuss the deprecated (now removed) v2.x members, but let me know if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 4409e9e)
(cherry picked from commit 4409e9e) Co-authored-by: Mike Woofter <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA:
Staging Links
https://deploy-preview-265--mongodb-docs-csharp.netlify.app/upgrade/v3
https://deploy-preview-265--mongodb-docs-csharp.netlify.app/compatibility
Self-Review Checklist