Skip to content

v3 fast follows #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

v3 fast follows #265

merged 2 commits into from
Oct 22, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Oct 18, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA:

Staging Links

https://deploy-preview-265--mongodb-docs-csharp.netlify.app/upgrade/v3
https://deploy-preview-265--mongodb-docs-csharp.netlify.app/compatibility

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for mongodb-docs-csharp ready!

Name Link
🔨 Latest commit 53908cc
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67182286f982660008595171
😎 Deploy Preview https://deploy-preview-265--mongodb-docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mayaraman19 mayaraman19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart requested review from a team and JamesKovacs and removed request for a team October 18, 2024 20:17
Copy link
Collaborator

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification requested around removal of the legacy shim mongocsharpdriver and the v2.x API deprecations.


- The v1.x legacy API, which was deprecated in v2, has been removed. If the driver
provides a replacement for a deprecated API, the compiler
messages in v2.x will display it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two separate issues here.

First the legacy v1.x API was removed. That was contained in the legacy shim mongocsharpdriver. If you're using those v1.x APIs, you need to migrate to the new API and we don't provide any upgrade guidelines. Very few users are still on the old v1.x API and thus we don't provide upgrade guidance. (We don't need to say that. Just FYI.)

Second the v2.x API contained a number of deprecations, which have been removed in 3.0.0. The 2.30.0 driver contains guidance in the form of deprecation warnings including the new APIs to use.

Copy link
Collaborator Author

@mongoKart mongoKart Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the clarification. It was hard to find specifics about this. I moved the legacy shim removal from What's New to Breaking Changes (since it will be, for anyone still using it) and changed the wording.

I believe the following two entries in the Upgrade Guide adequately discuss the deprecated (now removed) v2.x members, but let me know if not.

@mongoKart mongoKart requested a review from JamesKovacs October 22, 2024 22:09
Copy link
Collaborator

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart merged commit 4409e9e into mongodb:master Oct 22, 2024
5 of 6 checks passed
@mongoKart mongoKart deleted the v3-fast-follows branch October 22, 2024 22:17
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit 4409e9e)
mongoKart added a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit 4409e9e)

Co-authored-by: Mike Woofter <[email protected]>
mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants