-
Notifications
You must be signed in to change notification settings - Fork 25
Authentication refactor #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Co-authored-by: Rea Rustagi <[email protected]>
Everything else looks good. Thank you for the updates! |
|
||
.. code-block:: csharp | ||
|
||
var connectionString = "mongodb://<hostname>[:<port>]/?authMechanism=MONGODB-X509"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to tech reviewer: Rishit got a timeout exception when using this code sample to connect to his deployment. Is the code sample correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time-out problem related to wrong connection string (it should be mongo+srv
for Atlas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've provided list of additional steps to successful connection to Atlas with x509 certificate via Slack, we can discuss if some of the steps should be incorporated into the page.
---------------------------------------------- | ||
|
||
To use SCRAM to authenticate your MongoDB user, specify your | ||
MongoDB credentials, but don't specify an authentication mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for tech reviewer: Do we need to show how to explicitly specify SCRAM-1 or SCRAM-256? I assumed users would want to use the best one supported by their deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User can specify SCRAM-1 or SCRAM-256 explicitly by setting authMechanism
parameter. However if authMechanism
is omitted: driver tries to use more secure mechanism (SCRAM-256) if server supports it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user omits authMechanism
and the server doesn't support SCRAM-256, does the driver default to SCRAM-1?
I'm wondering if the user would ever need to explicitly specify SCRAM-1, or if the driver would automatically negotiate the most secure SCRAM protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v3.0 v3.0
# Navigate to the new working tree
cd .worktrees/backport-v3.0
# Create a new branch
git switch --create backport-284-to-v3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v3.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v3.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.30 v2.30
# Navigate to the new working tree
cd .worktrees/backport-v2.30
# Create a new branch
git switch --create backport-284-to-v2.30
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v2.30
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.30 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.29 v2.29
# Navigate to the new working tree
cd .worktrees/backport-v2.29
# Create a new branch
git switch --create backport-284-to-v2.29
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v2.29
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.29 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.28 v2.28
# Navigate to the new working tree
cd .worktrees/backport-v2.28
# Create a new branch
git switch --create backport-284-to-v2.28
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v2.28
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.28 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.27 v2.27
# Navigate to the new working tree
cd .worktrees/backport-v2.27
# Create a new branch
git switch --create backport-284-to-v2.27
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v2.27
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.27 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.26 v2.26
# Navigate to the new working tree
cd .worktrees/backport-v2.26
# Create a new branch
git switch --create backport-284-to-v2.26
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf67d808c3dc903d669f0891e611a57cd803f610
# Push it to GitHub
git push --set-upstream origin backport-284-to-v2.26
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.26 Then, create a pull request where the |
Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80)
Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80)
* Authentication refactor (#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80)
* Authentication refactor (#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80) (cherry picked from commit 3999260)
* Authentication refactor (#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80) (cherry picked from commit 3999260)
* Authentication refactor (#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80) (cherry picked from commit 3999260)
* Authentication refactor (mongodb#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80) (cherry picked from commit 3999260) (cherry picked from commit a162754)
Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit a162754)
Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit a162754) (cherry picked from commit 6f96497)
…ngodb#327) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit 6f96497) (cherry picked from commit f3eb7fc)
…ngodb#327) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit 6f96497) (cherry picked from commit f3eb7fc)
Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80)
* Authentication refactor (#284) Co-authored-by: Rea Rustagi <[email protected]> (cherry picked from commit bf67d80) (cherry picked from commit 3999260)
Co-authored-by: Rea Rustagi <[email protected]>
PR changes:
Pull Request Info
PR Reviewing Guidelines
JIRA:
Staging Links
Self-Review Checklist