-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-35724: $in operator documentation #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments!
source/fundamentals/atlas-search.txt
Outdated
:start-after: // start-in-search | ||
:end-before: // end-in-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:start-after: // start-in-search | |
:end-before: // end-in-search | |
:start-after: start-in-search | |
:end-before: end-in-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A symptom of me relying too much on Copilot autocomplete.
source/fundamentals/atlas-search.txt
Outdated
Use the ``In()`` method to search for documents that have field values matching a list | ||
of specified values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the ``In()`` method to search for documents that have field values matching a list | |
of specified values. | |
Use the ``In()`` method to search for documents with field values that match a list | |
of specified values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// start-in-search | ||
var guitarList = new[] { "Fender", "Gibson" }; | ||
var result = guitarsCollection.Aggregate() | ||
.Search(Builders<Guitar>.Search.In(g => g.Make, guitarList)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: could use new collection expression syntax:
.Search(Builders<Guitar>.Search.In(g => g.Make, ["Fender", "Gibson"]))
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
(cherry picked from commit 0dc9837)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-35724
Staging Links
Self-Review Checklist