Skip to content

DOCSP-35724: $in operator documentation #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Dec 12, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35724

Staging Links

  • fundamentals/atlas-search
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Dec 12, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit c6d271d
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/675c8ead472b710008aad73c
    😎 Deploy Preview https://deploy-preview-372--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review December 12, 2024 17:04
    Copy link
    Collaborator

    @mayaraman19 mayaraman19 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a few comments!

    Comment on lines 348 to 349
    :start-after: // start-in-search
    :end-before: // end-in-search
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    :start-after: // start-in-search
    :end-before: // end-in-search
    :start-after: start-in-search
    :end-before: end-in-search

    Copy link
    Collaborator Author

    @mcmorisi mcmorisi Dec 12, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A symptom of me relying too much on Copilot autocomplete.

    Comment on lines 341 to 342
    Use the ``In()`` method to search for documents that have field values matching a list
    of specified values.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Use the ``In()`` method to search for documents that have field values matching a list
    of specified values.
    Use the ``In()`` method to search for documents with field values that match a list
    of specified values.

    @mcmorisi mcmorisi requested review from a team and JamesKovacs and removed request for a team December 12, 2024 18:52
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    // start-in-search
    var guitarList = new[] { "Fender", "Gibson" };
    var result = guitarsCollection.Aggregate()
    .Search(Builders<Guitar>.Search.In(g => g.Make, guitarList))
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    minor: could use new collection expression syntax:
    .Search(Builders<Guitar>.Search.In(g => g.Make, ["Fender", "Gibson"]))

    @mcmorisi mcmorisi merged commit 0dc9837 into mongodb:master Dec 13, 2024
    4 of 6 checks passed
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mcmorisi added a commit that referenced this pull request Dec 13, 2024
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request Dec 20, 2024
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants