DOCSP-45943: dateonly serialization #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
force-pushed
the
DOCSP-45943-dateonly-serialization
branch
from
e171ba6 to
64727cd
Compare
mongoKart
approved these changes
Apr 4, 2025
papafe
reviewed
Apr 7, 2025
| - ``Representation``: Set to a ``BsonType`` instance that specifies how | ||
| the ``DateOnly`` value is stored in MongoDB. | ||
|
|
||
| - ``DocumentFormat``: Set to one of the following |
There was a problem hiding this comment.
I think here we need to spcify that DocumentFormat is an optional parameter and that is used only if Representation is BsonType.Document.
papafe
suggested changes
Apr 7, 2025
papafe
reviewed
Apr 9, 2025
source/whats-new.txt
Outdated
| @@ -122,6 +122,13 @@ The 3.2 driver release includes the following new features: | |||
| To learn more about Atlas Vector Search with the {+driver-short+}, see the | |||
| :ref:`csharp-atlas-vector-search` guide. | |||
|
|
|||
| - Adds the ``DocumentFormat`` property to the ``DateOnlySerializer``. | |||
| This property allows you to customize the way that the driver stores | |||
| ``DateOnly`` values in nested documents. This release also adds the | |||
There was a problem hiding this comment.
I think just saying "values" as it was before make more sense. Now it seems like it's influencing only DateOnly values in subdocuments.
papafe
reviewed
Apr 9, 2025
| - ``Representation``: Set to a ``BsonType`` instance that specifies how | ||
| the ``DateOnly`` value is stored in MongoDB. | ||
|
|
||
| - ``DocumentFormat``: Set only if you set the ``Representation`` |
There was a problem hiding this comment.
Maybe we can say something like "Sets the format to use for the document if Representation is BsonType.Document, ignored otherwise.
* DOCSP-48921: Server 8.1 compat * fix
rustagir
added a commit
that referenced
this pull request
Apr 9, 2025
* DOCSP-45943: dateonly serialization * MW PR fixes 1 * FP tech review * DOCSP-48936 - Add title length check (#571) * DOCSP-48921: Server 8.1 compat (#555) * DOCSP-48921: Server 8.1 compat * fix * Update upgrade.txt * add xs and note * DOCSP-45803: atlas search queries null & guid values (#582) * FP tech review2 --------- Co-authored-by: Mike Woofter <[email protected]> (cherry picked from commit da58c7d)
rustagir
added a commit
that referenced
this pull request
Apr 9, 2025
* DOCSP-45943: dateonly serialization * MW PR fixes 1 * FP tech review * DOCSP-48936 - Add title length check (#571) * DOCSP-48921: Server 8.1 compat (#555) * DOCSP-48921: Server 8.1 compat * fix * Update upgrade.txt * add xs and note * DOCSP-45803: atlas search queries null & guid values (#582) * FP tech review2 --------- Co-authored-by: Mike Woofter <[email protected]> (cherry picked from commit da58c7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45943
Staging Links
Self-Review Checklist