DOCSP-40227: memory serialization #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BorisDog
requested changes
Apr 11, 2025
| large numerical arrays. If your application uses | ||
| {+vector-search+}, you might benefit from the performance | ||
| improvements from using ``Memory`` and ``ReadOnlyMemory`` to model | ||
| vector data. To learn more, see :ref:`csharp-supported-vector-types` |
There was a problem hiding this comment.
It's probably worth mentioning the more significant optimization of using Binary Vector for vector search as well.
Or alternatively mention that this suggested optimization applied to Array representation of embeddings.
There was a problem hiding this comment.
I changed the wording here, but the linked page (atlas vector search) has a lot more info on the types/optimizations that are specific to vectors
|
|
||
| public class Program | ||
| { | ||
|
|
| arrays. | ||
|
|
||
| You can effect these performance improvements by storing the following | ||
| primitive types in ``Memory<T>`` or ``ReadOnlyMemory<T>`` objects: |
There was a problem hiding this comment.
It should be "structs" instead of "objects".
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
* DOCSP-40227: memory serialization * add note * MM PR fixes 1 * BD tech review comments 1 (cherry picked from commit 611a739)
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
* DOCSP-40227: memory serialization * add note * MM PR fixes 1 * BD tech review comments 1 (cherry picked from commit 611a739)
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
* DOCSP-40227: memory serialization * add note * MM PR fixes 1 * BD tech review comments 1 (cherry picked from commit 611a739)
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
rustagir
added a commit
that referenced
this pull request
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40227
Staging Links
new serialization section
whats new
atlas vector search
Self-Review Checklist