Skip to content

DOCSP-49056: Server Selection #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 21, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49056

Staging Links

  • connect/connection-options/server-selection
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 21, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit d8e3c95
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/6807eb4c4bee970008c0aa6b
    😎 Deploy Preview https://deploy-preview-618--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work! Just a few suggestions

    Comment on lines 52 to 53
    when you don't specify any custom server-selection logic, see
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S:

    Suggested change
    To learn more about the default server-selection algorithm, which the driver follows
    when you don't specify any custom server-selection logic, see
    The driver follows a default server-selection algorithm when you don't specify any custom server-selection logic. To learn more about the default server-selection algorithm, see

    * - ``ReadPreference``
    - | The client's default read-preference settings. ``MaxStaleness`` represents the
    | longest replication lag (in wall-clock time) that a secondary can experience and
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is wall-clock time a standard term? I've never heard that before

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks like it's one of many ways to refer to real time. Can change it to that instead.

    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi requested a review from sanych-sun April 21, 2025 17:20
    @mcmorisi mcmorisi requested a review from sanych-sun April 22, 2025 19:18
    Copy link
    Member

    @sanych-sun sanych-sun left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit 012b476 into mongodb:docsp-45382-comp-cvg Apr 22, 2025
    5 of 6 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants