Skip to content

DOCSP-49061 - Query filters (Comprehensive Coverage) #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: docsp-45382-comp-cvg
Choose a base branch
from

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Apr 28, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49061

Staging Links

  • crud/query/query-filter
  • crud/query
  • reference/compatibility
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 28, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit c505913
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/681a347ba93da2000884e98b
    😎 Deploy Preview https://deploy-preview-620--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.


    .. include:: /includes/method-overloads.rst

    Sample Data
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    These code examples will eventually be integrated into the server manual, at which time they will use the Atlas sample data. Missing code examples will also be added.

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with some nits! I like this page structure a lot.


    .. output::
    :language: json
    :visible:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit, also applies to the other occurences on the page.

    Suggested change
    :visible:
    :visible: false

    - :manual:`$size </reference/operator/query/size/>`

    The following example uses builders to create a query filter that matches all
    documents that have three elements in the ``models`` field:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nit: Might be helpful to specify.

    Suggested change
    documents that have three elements in the ``models`` field:
    documents that have exactly three elements in the ``models`` field:

    @mongoKart mongoKart changed the title DOCSP-49061 - Create a query filter DOCSP-49061 - Query filters (Comprehensive Coverage) Apr 29, 2025
    @mongoKart mongoKart requested review from a team and rstam and removed request for a team April 29, 2025 15:12
    of the string values in the query array.
    - :manual:`$in </reference/operator/query/in/>`

    The following example specifies a query filter as a parameter to the ``Find()``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Technically it specifies a predicate "lambda expression", which is translated by the driver into a "query filter".

    But you could use a loose definition of "query filter" to include lambda expressions if you want...

    the specified field.
    - :manual:`$bitsAllClear </reference/operator/query/bitsAllClear/>`

    * - ``bitsAllSet()``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Initial b should be capitalized: BitsAllSet

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good catch.

    the specified field.
    - :manual:`$bitsAllSet </reference/operator/query/bitsAllSet/>`

    * - ``bitsAnyClear()``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Initial b should be capitalized: BitsAnyClear

    the specified field.
    - :manual:`$bitsAnyClear </reference/operator/query/bitsAnyClear/>`

    * - ``bitsAnySet()``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Initial b should be capitalized: BitsAnySet

    @mongoKart mongoKart requested a review from rstam May 6, 2025 16:10
    Copy link
    Collaborator

    @rstam rstam left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants