-
Notifications
You must be signed in to change notification settings - Fork 25
DOCSP-49085: Port existing Vector Search page #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docsp-45382-comp-cvg
Are you sure you want to change the base?
DOCSP-49085: Port existing Vector Search page #643
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A few questions and comments.
guide, see the following API Documentation: | ||
|
||
- `BinaryVectorFloat32 <{+new-api-root+}/MongoDB.Bson/MongoDB.Bson.BinaryVectorFloat32.html>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[i] A few of these links were a 404:
- BinaryVectorFloat32
- BinaryVectorInt8
- BinaryVectorPackedBit
- ToQueryVector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So production is using C# version 3.4 and these links work – this is an issue specific to the comp cvg branch.
source/includes/fundamentals/code-examples/atlas-vector-search/VectorSearchQueryExample.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few fixes but don't think those require a re-review 🚢
Pull Request Info
READ BEFORE REVIEW
Rea created a Vector Search page since we started the CC branch. The majority of this PR is pulling her page in with a few extras, namely:
Everything else was previously reviewed
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49085
Staging Links
Self-Review Checklist