Skip to content

[Docs+] Getting Started With MongoDB and FastAPI #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

rachel-mack
Copy link
Collaborator

@rachel-mack rachel-mack commented Apr 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48895

Staging Links

  • integrations/fastapi-integration
  • connect
  • integrations
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 8, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit bf9ed18
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/681b72ac3ee14a0008139392
    😎 Deploy Preview https://deploy-preview-250--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @rachel-mack rachel-mack marked this pull request as ready for review May 2, 2025 16:40
    @rustagir rustagir self-requested a review May 5, 2025 13:47
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I reviewed 2/3 of the PR but there are a lot of formatting and style guide issues that It would be good for you to correct before I take a second pass. Let me know if you have any questions!

    uvicorn app:app --reload

    .. image:: /includes/integrations/fastapi-terminal.png
    :alt: Screenshot of terminal running FastAPI
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This step has a lot of indentation errors


    All the code for the example application is stored in ``app.py``.

    Connect to your MongoDB Atlas cluster using the asynchronous `Pymongo Driver <https://www.mongodb.com/docs/languages/python/pymongo-driver/current>`__, then specify the database named ``college``:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Since this page is now in the pymongo docs, change this link out for something that makes more sense (and use a ref)

    Comment on lines 113 to 117
    FastAPI encodes and decodes data as JSON strings, which do not support all of the
    data types that MongoDB's BSON data type can store. BSON has support for
    additional non-JSON-native data types, including ``ObjectId`` which is used for
    the default UUID attribute, ``_id``. Because of this, you must convert
    ``ObjectId`` objects to strings before storing them in the ``_id`` field.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: fix indentation

    Comment on lines 126 to 127
    # Represents an ObjectId field in the database.
    # It will be represented as a `str` on the model so that it can be
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: move code to file where possible


    This is the primary model we use as the `response model <https://fastapi.tiangolo.com/tutorial/response-model/>`__ for the majority of our endpoints.

    I want to draw attention to the ``id`` field on this model. MongoDB uses ``_id``, but in Python, underscores at the start of attributes have special meaning. If you have an attribute on your model that starts with an underscore, `pydantic <https://pydantic-docs.helpmanual.io/>`__—the data validation framework used by FastAPI—will assume that it is a private variable, meaning you will not be able to assign it a value! To get around this, we name the field ``id`` but give it an alias of ``_id``. You also need to set ``populate_by_name`` to ``True`` in the model's ``model_config``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: fix for lots of style guide errors

    @rachel-mack rachel-mack requested a review from rustagir May 7, 2025 14:56
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    still a lot of issues to resolve, I am going OOO so perhaps another team member can pick this up!

    Comment on lines +197 to +198
    - It does not have an ``id`` attribute, as this cannot be modified
    - - All fields are optional, so you can supply only the fields you want to update
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: list issues

    Create Your Application Routes
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Our application has five routes:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Our application has five routes:
    The following table describes the application routes you must create to interact with data:

    Comment on lines +319 to +320
    The application has two read routes: one for viewing all students, and one
    for viewing an individual student specified by their ``id``.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: convert into a list

    Comment on lines +343 to +345
    recommend using the `skip and limit parameters
    <https://pymongo.readthedocs.io/en/stable/api/pymongo/asynchronous/collection.html#pymongo.asynchronous.collection.AsyncCollection.find>`__
    in ``find`` to paginate your results.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: not sure why formatting is off here - also use __ at the end of urls (2 underscores)

    Comment on lines +383 to +385
    <https://pymongo.readthedocs.io/en/stable/api/pymongo/asynchronous/collection.html#pymongo.asynchronous.collection.AsyncCollection.find_one_and_update>`__
    to `$set <https://docs.mongodb.com/manual/reference/operator/update/set/>`__
    the new values, and then return the updated document.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Use native links such as source constants for API links and :manual:

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants