CDRIVER-5756 Coverity fixes #1867
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID: 100057
CID: 100087
CID: 115840, 115848, 115851, 115853
CID: 134019
CID: 138986
CID: 138989
CID: 156373
CID: 157950
Comment on lines
+314
to
+319
| bson_mutex_lock (&topology->tpld_modification_mtx); | ||
| for (size_t i = 0u; i < n_rtt_monitors; i++) { | ||
| server_monitor = mongoc_set_get_item (topology->rtt_monitors, i); | ||
| mongoc_server_monitor_request_shutdown (server_monitor); | ||
| } | ||
| bson_mutex_unlock (&topology->tpld_modification_mtx); |
There was a problem hiding this comment.
I'm not sure if this mutex is relevant here. Do you have a link to the Coverity warning related to these lines?
There was a problem hiding this comment.
I sent you the link in a DM.
kevinAlbs
reviewed
Feb 19, 2025
kevinAlbs
reviewed
May 9, 2025
Co-authored-by: Kevin Albertson <[email protected]>
|
Here is the patch build for the latest changes. Also, I have checked the Coverity dashboard and there are no new detections that need to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some small Coverity issues (w/ full Evergreen patch build).
@kevinAlbs I wasn't sure who would be available to review, so please feel free to adjust the reviewers as needed.