CDRIVER-938 prohibit calling unsafe client setters with pooled clients #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
mongoc_client_set_ssl_opts
andmongoc_client_set_ssl_stream_initiator
to ignore a pooledmongoc_client_t
and logs an error.Motivation
Intended to prevent a user configuring connection options on a pooled client that likely behave unexpectedly:
Other
mongoc_client_set_*
functions are not modified.Changes to
mongoc_client_set_*
functionsmongoc_client_set_ssl_opts
andmongoc_client_set_ssl_stream_initiator
mongoc_client_set_sockettimeoutms
mongoc_client_set_write_concern
,mongoc_client_set_read_concern
, andmongoc_client_set_read_prefs
mongoc_client_set_apm_callbacks
,mongoc_client_set_structured_log_opts
,mongoc_client_set_error_api
,mongoc_client_set_appname
,mongoc_client_set_server_api