Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDRIVER-5949 remove deprecated database API #1960

Merged
merged 5 commits into from
Mar 31, 2025

Conversation

kevinAlbs
Copy link
Collaborator

Summary

  • remove mongoc_database_find_collections
  • remove mongoc_database_get_collection_names

* remove `mongoc_database_find_collections`
* remove `mongoc_database_get_collection_names`
remove `test_get_collection_info_regex` entirely since `test_get_collection_info_regex_with_opts` tests `mongoc_database_find_collections_with_opts`
Copy link
Collaborator

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's one typo.

NEWS Outdated
@@ -56,6 +56,9 @@ Unreleased (2.0.0)
* `mongoc_index_opt_t`, `mongoc_index_opt_geo_t` `mongoc_index_opt_wt_t` are removed. Pass options using `bson_t` to `mongoc_collection_create_indexes_with_opts` instead.
* `mongoc_collection_find_indexes` is removed. Use `mongoc_collection_find_indexes_with_opts` instead.
* See [MongoDB documentation](https://www.mongodb.com/docs/languages/c/c-driver/current/indexes/) for working with indexes.
* Deprecated API for `mongoc_database_t` has been removed:
* `mongoc_database_find_collections` is removed. Use `mongoc_database_find_collections_with_opts` instead.
* `mongoc_database_get_collection_names` is removed. Use `mongoc_database_get_collection_names` instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"X is removed. Use X instead" Typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Fixed. The expected alternative is mongoc_database_get_collection_names_with_opts.

@kevinAlbs kevinAlbs merged commit 1b6b6d4 into mongodb:master Mar 31, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants