CSHARP-5463: Investigate whether calls to EnsureQueryableMethodHasNestedAsQueryableSource are actually needed. #1669
+94
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tedAsQueryableSource are actually needed.
rstam
commented
Apr 12, 2025
| @@ -27,7 +27,7 @@ public static void EnsureQueryableMethodHasNestedAsQueryableSource(MethodCallExp | |||
| if (expression.Method.DeclaringType == typeof(Queryable) && | |||
| sourceTranslation.Serializer is not INestedAsQueryableSerializer) | |||
| { | |||
| throw new ExpressionNotSupportedException(expression, because: "source serializer is not a NestedAsQueryableSerializer"); | |||
| throw new ExpressionNotSupportedException(expression, because: "source argument is an unsupported IQueryable type"); | |||
There was a problem hiding this comment.
Maybe the message should be even more descriptive?
For example, it could include the type of the unsupported IQueryable...
| var enumerable = new int[] { 1, 2, 3 }; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Select(x => enumerable.AsQueryable().Contains(1)); |
There was a problem hiding this comment.
This is the nested AsQueryable we've been supporting all along.
| var nestedQueryable = new int[] { 1, 2, 3 }.AsQueryable(); | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Select(x => nestedQueryable.Contains(1)); // PartialEvaluator turns this into Select(x => true) |
There was a problem hiding this comment.
This one doesn't trigger an error because the entire nested queryable expression is evaluated by the partial evaluator.
| var nestedQueryable = new int[] { 1, 2, 3 }.AsQueryable(); | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Select(x => nestedQueryable.Contains(x.Id)); |
There was a problem hiding this comment.
This one triggers an error because the translator doesn't know how to translate nestedAsQueryable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably have a Zoom meeting to discuss this one.