GODRIVER-2901 Refactor operation.Execute#2451
Draft
matthewdale wants to merge 3 commits into
Draft
Conversation
Pull the single round-trip work (maxTimeMS calculation, wire message construction, APM event publishing, compression, CSOT deadline check, and network round trip) out of Execute into a new executeAttempt method. The new attemptResult type carries res, moreToCome, and processedBatches back to the caller, replacing the now-removed local variables.
Contributor
API Change ReportNo changes found! |
Contributor
🧪 Performance ResultsCommit SHA: 858b00aThe following benchmark tests for version 6a4423c41280ab0007196c4d had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background & Motivation