SQL-2737: Add thirdparty notices as artifacts #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… standalone task to validate it works
bucaojit
approved these changes
Apr 8, 2025
resources/third_party_header.txt
Outdated
| @@ -0,0 +1,13 @@ | |||
| MongoDB uses third-party libraries or other resources that may | |||
| be distributed under licenses different than the MongoDB software. | |||
There was a problem hiding this comment.
Suggested change
| be distributed under licenses different than the MongoDB software. | |
| be distributed under licenses different from the MongoDB software. |
resources/third_party_header.txt
Outdated
| MongoDB uses third-party libraries or other resources that may | ||
| be distributed under licenses different than the MongoDB software. | ||
|
|
||
| In the event that we accidentally failed to list a required notice, |
There was a problem hiding this comment.
Suggested change
| In the event that we accidentally failed to list a required notice, | |
| In the event that we accidentally fail to list a required notice, |
gradle/publish.gradle
Outdated
| dependencyNode.appendNode('groupId', artifact.moduleVersion.id.group) | ||
| dependencyNode.appendNode('artifactId', artifact.name) | ||
| dependencyNode.appendNode('version', artifact.moduleVersion.id.version) | ||
| dependencyNode.appendNode('scope', 'runtime') |
There was a problem hiding this comment.
nit: I see in our previous release dependencies that mongodb-driver-sync has a scope of compile. Here it will be runtime, to be consistent we can set that to compile.
jchemburkar
approved these changes
Apr 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
* Add thirdparty notices as artifacts * Generating thirparty license notices at publication time and adding a standalone task to validate it works * Publish pom with fixed version to be consumable downstream * Adding missing new line at the end of the file * Only list first level runtime dependencies * Fix thirdparty license notice header typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.