SQL-2778: Update mongo-jdbc-driver to use the new run_adf.sh script #359
+71
−563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucaojit
commented
Jun 13, 2025
| @@ -726,13 +753,13 @@ functions: | |||
| TIMEOUT=1800 # 30 minute timeout | |||
| while true; do | |||
| if grep -q "BUILD SUCCESSFUL" gradle_output.log; then | |||
| if grep -q "BUILD SUCCESSFUL" gradle_output.log 2>/dev/null; then | |||
There was a problem hiding this comment.
Adding these here to clean up the log outputs: grep: gradle_output.log: No such file or directory
mattChiaravalloti
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Looks great 💯 Thank you for figuring out the compute-node issue and resolving it in common-test-infra 💪 this is looking nice.
Will we remove the local resources/run_adf.sh script from this repo in a follow-up PR after SQL-2777 is resolved in the mongohouse repo?
|
@mattChiaravalloti Thanks. |
EthanHardyMongo
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
start_compute_node.shin this PR in sql-engines-common-test-infra. I'll wait until this change is merged before adding reviewers.Successful patch here.
Updated integration test that checks database names as this is different with the common-test-infra run_adf.sh changes.