PHPLIB-1330: Update skipped test list to account for moved test #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are due to Azure credentials needing to be rotated. I'll re-run the patch once that was done. |
jmikola
approved these changes
Feb 7, 2024
| 'transactions/mongos-recovery-token: commitTransaction retry fails on new mongos' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/mongos-recovery-token: abortTransaction sends recoveryToken' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/pin-mongos: multiple commits' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/pin-mongos: remain pinned after non-transient error on commit' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/pin-mongos: unpin after transient error within a transaction' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/pin-mongos: unpin after transient error within a transaction and commit' => 'libmongoc does not pin for load-balanced topology', | ||
| 'transactions/mongos-recovery-token-errorLabels: commitTransaction retry succeeds on new mongos' => 'libmongoc does not pin for load-balanced topology', |
There was a problem hiding this comment.
I'll incorporate this into #1226
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Feb 7, 2024
See: mongodb#1228 Also updates a reference to a moved JIRA issue
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Feb 8, 2024
See: mongodb#1228 Also updates a reference to a moved JIRA issue
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Feb 9, 2024
See: mongodb#1228 Also updates a reference to a moved JIRA issue
jmikola
added a commit
that referenced
this pull request
Feb 16, 2024
* Support createEntities test runner operation and clarify that other syntax from schema 1.9 has not been implemented * Remove redundant logic for preventStaleDbVersionError() in Operation UnifiedTestRunner::preventStaleDbVersionError() already handles this. The Operation code was likely always redundant and dates back to the original test runner implementation in 4608a73. * Preserve skip logic for ported legacy transaction tests * Update path for relocated skipped test See: #1228 Also updates a reference to a moved JIRA issue * Remove legacy transaction spec tests * Sync transactions and transactions-convenient-api spec tests Synced with mongodb/specifications@e51a7bc * Remove legacy transaction-convenient-api spec tests * PHPLIB-1397: Update tests for skipping LB topologies for targetedFailPoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1330 pulled in a new test file that was extracted for compatibility with different runOnRequirements. The pull request in question however broke load-balanced tests as it didn't rename the incomplete test.
We currently don't run load-balanced tests in pull request - is that something we should add?