-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPLIB-1330: Update skipped test list to account for moved test #1228
PHPLIB-1330: Update skipped test list to account for moved test #1228
Conversation
Failures are due to Azure credentials needing to be rotated. I'll re-run the patch once that was done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't run load-balanced tests in pull request - is that something we should add?
Absolutely worth adding. I didn't realize LB was missing, but I do see API version tasks are there and LB is at least as important.
'transactions/mongos-recovery-token: commitTransaction retry fails on new mongos' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/mongos-recovery-token: abortTransaction sends recoveryToken' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/pin-mongos: multiple commits' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/pin-mongos: remain pinned after non-transient error on commit' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/pin-mongos: unpin after transient error within a transaction' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/pin-mongos: unpin after transient error within a transaction and commit' => 'libmongoc does not pin for load-balanced topology', | ||
'transactions/mongos-recovery-token-errorLabels: commitTransaction retry succeeds on new mongos' => 'libmongoc does not pin for load-balanced topology', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll incorporate this into #1226
See: mongodb#1228 Also updates a reference to a moved JIRA issue
See: mongodb#1228 Also updates a reference to a moved JIRA issue
See: mongodb#1228 Also updates a reference to a moved JIRA issue
* Support createEntities test runner operation and clarify that other syntax from schema 1.9 has not been implemented * Remove redundant logic for preventStaleDbVersionError() in Operation UnifiedTestRunner::preventStaleDbVersionError() already handles this. The Operation code was likely always redundant and dates back to the original test runner implementation in 4608a73. * Preserve skip logic for ported legacy transaction tests * Update path for relocated skipped test See: #1228 Also updates a reference to a moved JIRA issue * Remove legacy transaction spec tests * Sync transactions and transactions-convenient-api spec tests Synced with mongodb/specifications@e51a7bc * Remove legacy transaction-convenient-api spec tests * PHPLIB-1397: Update tests for skipping LB topologies for targetedFailPoint
PHPLIB-1330 pulled in a new test file that was extracted for compatibility with different runOnRequirements. The pull request in question however broke load-balanced tests as it didn't rename the incomplete test.
We currently don't run load-balanced tests in pull request - is that something we should add?