Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1330: Update skipped test list to account for moved test #1228

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 7, 2024

PHPLIB-1330 pulled in a new test file that was extracted for compatibility with different runOnRequirements. The pull request in question however broke load-balanced tests as it didn't rename the incomplete test.

We currently don't run load-balanced tests in pull request - is that something we should add?

@alcaeus alcaeus requested a review from jmikola February 7, 2024 13:43
@alcaeus alcaeus self-assigned this Feb 7, 2024
@alcaeus
Copy link
Member Author

alcaeus commented Feb 7, 2024

Failures are due to Azure credentials needing to be rotated. I'll re-run the patch once that was done.

Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't run load-balanced tests in pull request - is that something we should add?

Absolutely worth adding. I didn't realize LB was missing, but I do see API version tasks are there and LB is at least as important.

'transactions/mongos-recovery-token: commitTransaction retry fails on new mongos' => 'libmongoc does not pin for load-balanced topology',
'transactions/mongos-recovery-token: abortTransaction sends recoveryToken' => 'libmongoc does not pin for load-balanced topology',
'transactions/pin-mongos: multiple commits' => 'libmongoc does not pin for load-balanced topology',
'transactions/pin-mongos: remain pinned after non-transient error on commit' => 'libmongoc does not pin for load-balanced topology',
'transactions/pin-mongos: unpin after transient error within a transaction' => 'libmongoc does not pin for load-balanced topology',
'transactions/pin-mongos: unpin after transient error within a transaction and commit' => 'libmongoc does not pin for load-balanced topology',
'transactions/mongos-recovery-token-errorLabels: commitTransaction retry succeeds on new mongos' => 'libmongoc does not pin for load-balanced topology',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll incorporate this into #1226

jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 7, 2024
See: mongodb#1228

Also updates a reference to a moved JIRA issue
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 8, 2024
See: mongodb#1228

Also updates a reference to a moved JIRA issue
@alcaeus alcaeus merged commit feefee8 into mongodb:master Feb 8, 2024
14 checks passed
@alcaeus alcaeus deleted the phplib-1330-skip-incomplete-load-balancer-test branch February 8, 2024 18:54
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 9, 2024
See: mongodb#1228

Also updates a reference to a moved JIRA issue
jmikola added a commit that referenced this pull request Feb 16, 2024
* Support createEntities test runner operation and clarify that other syntax from schema 1.9 has not been implemented

* Remove redundant logic for preventStaleDbVersionError() in Operation

UnifiedTestRunner::preventStaleDbVersionError() already handles this. The Operation code was likely always redundant and dates back to the original test runner implementation in 4608a73.

* Preserve skip logic for ported legacy transaction tests

* Update path for relocated skipped test

See: #1228

Also updates a reference to a moved JIRA issue

* Remove legacy transaction spec tests

* Sync transactions and transactions-convenient-api spec tests

Synced with mongodb/specifications@e51a7bc

* Remove legacy transaction-convenient-api spec tests

* PHPLIB-1397: Update tests for skipping LB topologies for targetedFailPoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants