Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1400: Work around MigrationConflict errors on sharded clusters #1232

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Feb 21, 2024

@jmikola jmikola marked this pull request as ready for review February 21, 2024 21:52
@jmikola jmikola changed the title DRIVERS-2816: Work around MigrationConflict errors on sharded clusters PHPLIB-1400: Work around MigrationConflict errors on sharded clusters Feb 22, 2024
@jmikola jmikola requested a review from alcaeus February 22, 2024 20:26
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to include this in v1.17 to avoid test failures there as well?

@jmikola jmikola merged commit 8b2c052 into mongodb:master Feb 23, 2024
14 checks passed
@jmikola jmikola deleted the poc-drivers-2816 branch February 23, 2024 14:29
@jmikola
Copy link
Member Author

jmikola commented Feb 23, 2024

Do we want to include this in v1.17 to avoid test failures there as well?

Saw this after merging. I cherry-picked this into v1.17 in a5a39ec, which resulted in an extra commit when merging v1.17 back up to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants