DOCSP-36627: Additional double backslash fixes for v1.17 #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Mar 4, 2024
jmikola
commented
Mar 4, 2024
jmikola
force-pushed
the
1.17-docsp-36627
branch
from
0763b50 to
af0f162
Compare
jmikola
force-pushed
the
1.17-docsp-36627
branch
from
af0f162 to
902fb55
Compare
jmikola
force-pushed
the
1.17-docsp-36627
branch
from
902fb55 to
6c18f10
Compare
jmikola
commented
Mar 4, 2024
| @@ -15,7 +15,7 @@ MongoDB\\add_logger() | |||
| Definition | |||
| ---------- | |||
|
|
|||
| .. phpmethod:: MongoDB\\add_logger() | |||
| .. phpmethod:: MongoDB\add_logger() | |||
There was a problem hiding this comment.
@norareidy: The "Behavior" section later in this file has:
`Psr\\Log\\LoggerInterface <https://www.php-fig.org/psr/psr-3/#3-psrlogloggerinterface>`__I assume the escaping there needs to stay since it's basic link syntax? We only need to remove escaping within directives.
Similar to what you had to do in https://github.com/mongodb/mongo-php-library/pull/1244/files#diff-0494d8195d629119e6de652538a76bd23063d2234cf08cad50eeebc94e6dee99R34
There was a problem hiding this comment.
Yeah, the \\ should stay in that case since it's not a directive
norareidy
approved these changes
Mar 4, 2024
| @@ -15,7 +15,7 @@ MongoDB\\add_logger() | |||
| Definition | |||
| ---------- | |||
|
|
|||
| .. phpmethod:: MongoDB\\add_logger() | |||
| .. phpmethod:: MongoDB\add_logger() | |||
There was a problem hiding this comment.
Yeah, the \\ should stay in that case since it's not a directive
jmikola
added a commit
that referenced
this pull request
Mar 5, 2024
* DOCSP-36627: Additional double backslash fixes for v1.17 (#1243) Co-authored-by: Nora Reidy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #1239 from v1.16 up to v1.17 and applies additional fixes.
/cc @norareidy (I'm unable to tag you for review)