Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1408: Convert ADL spec test to unified test format #1250

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 8, 2024

@jmikola jmikola marked this pull request as ready for review March 11, 2024 14:42
@jmikola jmikola requested a review from a team as a code owner March 11, 2024 14:42
@jmikola jmikola requested review from alcaeus and GromNaN March 11, 2024 14:42
@jmikola
Copy link
Member Author

jmikola commented Mar 11, 2024

Note: phpcs errors will be addressed by #1251

jmikola added 2 commits March 12, 2024 10:41
Synced with mongodb/specifications#1545

Moves isAtlasDataLake() function to FunctionalTestCase, since it is now shared across test files.

Fixes typo in ADL prose test comment.
@jmikola jmikola merged commit e147669 into mongodb:master Mar 12, 2024
16 checks passed
@jmikola jmikola deleted the phplib-1408 branch March 12, 2024 15:06
alcaeus added a commit that referenced this pull request May 10, 2024
* v1.18: (50 commits)
  Enable auto-merge in merge-up workflow (#1295)
  PHPLIB-1447: Add SBOM lite (#1292)
  Fix syntax error in docs (#1285)
  PHPLIB-1163 Create tutorial for using MongoDB with Bref (#1273) (#1282)
  Create sarif report when running psalm (#1280)
  Update composer.json and CI matrices for 1.18.0
  PHPLIB-1410: Invoke drivers-evergreen-tools scripts with bash (#1267)
  PHPLIB-1302: Use Composer\InstalledVersions (#1262)
  PHPLIB-1320: Support "comment" command option in Collection::createIndex() (#1263)
  PHPLIB-1413: Use env instead of matrix for driver-version (#1261)
  Fix Markdown heading
  PHPLIB-1399: Docs examples for agg expr projection (#1260)
  PHPLIB-1412: Skip range encryption tests on MongoDB 8.0+ (#1259)
  PHPLIB-1409: Skip $out and mapReduce tests on serverless (#1254)
  Exclude read-write-concern tests from serverless testing (#1253)
  PHPLIB-1409: Convert default write concern tests to unified test format (#1252)
  PHPLIB-1408: Convert ADL spec test to unified test format (#1250)
  Remove redundant annotations (#1251)
  PHPLIB-1404: Convert retryable reads spec tests to unified test format  (#1247)
  DOCSP-36627: Additional double backslash fixes for master (#1246)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants