PHPLIB-1613 Load drivers-evergreen-tools using submodule #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Feb 7, 2025
.gitmodules
Outdated
| @@ -1,3 +1,6 @@ | |||
| [submodule "drivers-tools"] | |||
| path = tests/drivers-tools | |||
There was a problem hiding this comment.
I realize we use this for both Evergreen and GitHub CI, but would it be preferable to keep the path consistent with the repository name?
GromNaN
force-pushed
the
PHPLIB-1613
branch
2 times, most recently
from
bef4a4c to
3af5416
Compare
jmikola
approved these changes
Feb 7, 2025
|
I think there is a configuration of dependabot to do to ensure we get distinct PR for each submodule. The solution might be to create groups: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates |
|
I'm merging the PR as the last dependabot PR #1587 is failing and I suspect the commit mongodb-labs/drivers-evergreen-tools@31d5280 We will figure the best dependabot configuration in an other PR. |
This was referenced Feb 10, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1613