PHPLIB-1492: Support sort option for updateOne and replaceOne #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Feb 24, 2025
Comment on lines
+432
to
+434
| if (isset($args[2]['sort']) && $args[2]['multi']) { | ||
| throw new InvalidArgumentException(sprintf('"sort" option cannot be used with $operations[%d]["%s"]', $i, $type)); | ||
| } |
There was a problem hiding this comment.
Noted that the multi option cannot true for replaceOne, that why the validation is only for updateMany and updateOne.
alcaeus
approved these changes
Feb 25, 2025
Addresses both single-statement updates and bulk writes.
jmikola
force-pushed
the
1.x-phplib-1492
branch
from
948dd9a to
694a2c2
Compare
jmikola
force-pushed
the
1.x-phplib-1492
branch
from
c9ad572 to
7f6c3cf
Compare
GromNaN
approved these changes
Feb 25, 2025
This was referenced Feb 25, 2025
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1492
Addresses both single-statement updates and bulk writes.
This will depend on mongodb/mongo-php-driver#1794 being merged.