Pre-init all sub-encoders of the builder encoder #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use weak reference to prevent circular reference Avoid having the same encoder initialized multiple times
alcaeus
approved these changes
Feb 26, 2025
| trait RecursiveEncode | ||
| { | ||
| final public function __construct(protected readonly BuilderEncoder $encoder) | ||
| /** @param WeakReference<Encoder> $encoder */ | ||
| final public function __construct(private readonly WeakReference $encoder) |
There was a problem hiding this comment.
Is there a way to enforce the type of the class the WeakReference is pointing to? Would that entail checking the type of $encoder->get() and manually throwing a TypeError if it's wrong?
I don't think we need to do this here since this is an internal trait, mainly just asking out of curiosity.
There was a problem hiding this comment.
You would like native support for generics, that doesn't exist.
Also, the WeakReference class is final, we cannot extend it to restrict the type.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeakReferenceto prevent circular referenceThe overhead of instantiating all these objects in the constructor is offset by the fact that we don't have to check each call.