Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies #1621

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Remove unneeded dependencies #1621

merged 1 commit into from
Feb 28, 2025

Conversation

remicollet
Copy link
Contributor

  • hash is always present (cannot be disabled)
  • json is always present since 8.0
  • polyfills no more needed as 8.1 is required

@remicollet remicollet requested a review from a team as a code owner February 28, 2025 14:12
@remicollet remicollet requested a review from GromNaN February 28, 2025 14:12
"ext-mongodb": "^1.21.0",
"composer-runtime-api": "^2.0",
"psr/log": "^1.1.4|^2|^3",
"symfony/polyfill-php80": "^1.27",
"symfony/polyfill-php81": "^1.27"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were also removed in #1619, but there doesn't appear to be any conflict here.

Copy link
Member

@GromNaN GromNaN Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because Git is smart enough to detect that's the exact same changes.

@GromNaN GromNaN changed the base branch from v1.x to v1.21 February 28, 2025 16:45
@GromNaN GromNaN merged commit 37bc8df into mongodb:v1.21 Feb 28, 2025
31 checks passed
@GromNaN
Copy link
Member

GromNaN commented Feb 28, 2025

Thank you @remicollet

This was referenced Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants