Skip to content

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 18, 2025

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.74%. Comparing base (8eb0501) to head (2d1895b).
⚠️ Report is 1 commits behind head on v2.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               v2.x    #1814      +/-   ##
============================================
+ Coverage     87.72%   87.74%   +0.01%     
+ Complexity     3195     3185      -10     
============================================
  Files           424      424              
  Lines          6296     6289       -7     
============================================
- Hits           5523     5518       -5     
+ Misses          773      771       -2     
Flag Coverage Δ
6.0-replica_set 85.72% <ø> (+0.01%) ⬆️
6.0-server 81.71% <ø> (+0.01%) ⬆️
6.0-sharded_cluster 85.51% <ø> (+0.22%) ⬆️
8.0-replica_set 87.66% <ø> (+0.01%) ⬆️
8.0-server 82.55% <ø> (+0.01%) ⬆️
8.0-sharded_cluster 87.50% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="6.5.1@3f17a6b24a2dbe543e21408c2b19108cf6a355ef">
<files psalm-version="6.14.2@bbd217fc98c0daa0a13aea2a7f119d03ba3fc9a0">
<file src="examples/aggregate.php">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm is unable to understand the return type of $client->__get():

public function __get(string $databaseName): Database

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +430 to +251
<InvalidAttribute>
<code><![CDATA[NoDiscard]]></code>
<code><![CDATA[NoDiscard]]></code>
</InvalidAttribute>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm doesn't know this new attribute.

@GromNaN GromNaN force-pushed the PHPLIB-1752 branch 2 times, most recently from 4860d31 to eb1f6b2 Compare December 18, 2025 14:10
@GromNaN GromNaN marked this pull request as ready for review December 18, 2025 15:31
@GromNaN GromNaN requested a review from a team as a code owner December 18, 2025 15:31
@GromNaN GromNaN requested review from Copilot and jmikola December 18, 2025 15:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Psalm static analysis tool from version 6.5 to 6.14.2 and updates the PHP version used in CI workflows from 8.2 to 8.5.

Key changes:

  • Upgraded Psalm dependency and updated baseline file with new version-specific suppressions
  • Added @psalm-no-seal-properties annotations to Client and Database classes
  • Updated static analysis workflow to use PHP 8.5

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
composer.json Updated Psalm version constraint from 6.5.* to ~6.14.2
psalm-baseline.xml Updated baseline with new Psalm version and added/removed issue suppressions
psalm.xml.dist Added suppressions for MissingOverrideAttribute and ClassMustBeFinal issues
src/Client.php Added @psalm-no-seal-properties annotation to prevent property sealing
src/Database.php Added @psalm-no-seal-properties annotation to prevent property sealing
.github/workflows/static-analysis.yml Updated PHP version from 8.2 to 8.5 for static analysis

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants