PYTHON-5286 Create server version variants #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage failure is expected since none of the old tasks were run as part of the PR build. |
NoahStapp
requested changes
Apr 9, 2025
| task_types.append((python, topology)) | ||
| for python, topology in task_types: | ||
| tags = ["server-version"] | ||
| if topology == "standalone": |
There was a problem hiding this comment.
Do we have any concern with a potential auth/ssl bug only showing up on a specific topology?
There was a problem hiding this comment.
Updated, I'll re-request review once the build passes.
NoahStapp
previously approved these changes
Apr 9, 2025
|
evergreen retry |
1 similar comment
|
evergreen retry |
|
Hmm, that's too many to run with a PR, I'll need to add more tags. |
|
evergreen retry |
3 similar comments
|
evergreen retry |
|
evergreen retry |
|
evergreen retry |
|
evergreen retry |
1 similar comment
|
evergreen retry |
|
Okay I got the PR tasks working as expected, including coverage. |
NoahStapp
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing build: https://spruce.mongodb.com/version/67f6939592c71a0007a6c40a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Before: 567 tasks across 9 build variants (we had No C in two places).
After: 153 tasks across 9 build variants,
I also disabled coverage on PyPy, which seems to have reduced its flakiness. The only consistent failure is the one fixed by #2268.
I decided to reduce the matrix by only testing all Python versions on sharded_cluster, and then sprinkling the python versions across the other topologies and auth/ssl combinations.
I'll update the default PR tasks after merging.