-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5288: SRV hostname validation fails when resolver and resolved hostnames are identical with three domain levels #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
pymongo/synchronous/srv_resolver.py:140
- [nitpick] Consider assigning node[0].lower() to a variable (e.g., host) to improve readability and avoid repeated method calls.
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
pymongo/asynchronous/srv_resolver.py:140
- [nitpick] Consider assigning node[0].lower() to a variable (e.g., host) to improve readability and avoid repeated method calls.
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the PR title to be more descriptive (and include the jira ticket) and add a changelog entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Looks good, let's add the changelog entry. |
… hostnames are identical with three domain levels (mongodb#2272) (cherry picked from commit 86e221e)
No description provided.