Skip to content

PYTHON-5297 - AsyncMongoClient connection error causes UnboundLocalError #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

PYTHON-5297 - AsyncMongoClient connection error causes UnboundLocalError #2273

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e10856c
PYTHON-5297 - AsyncMongoClient connection error causes UnboundLocalError
NoahStapp Apr 9, 2025
6187706
Update changelog
NoahStapp Apr 9, 2025
05da9df
Merge branch 'master' into PYTHON-5297
NoahStapp Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pymongo/pool_shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,12 +346,10 @@ async def _configured_protocol_interface(
ssl=ssl_context,
)
except _CertificateError:
transport.abort()
# Raise _CertificateError directly like we do after match_hostname
# below.
raise
except (OSError, SSLError) as exc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still call transport.abort() when match_hostname fails below. What happens after abort is called? Don't we need to reap the background tasks somehow to avoid "Task was never awaited" warnings??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any background tasks associated with the transport, protocol pair here. Are you referring to the monitor background tasks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I forgot it's callback based.

transport.abort()
# We raise AutoReconnect for transient and permanent SSL handshake
# failures alike. Permanent handshake failures, like protocol
# mismatch, will be turned into ServerSelectionTimeoutErrors later.
Expand Down
Loading