CLOUDP-305560: Add Atlas Integration CRD #2184
Conversation
josvazg
force-pushed
the
CLOUDP-305560/add-integrations-crd
branch
2 times, most recently
from
a6b98f6 to
4bbdbcb
Compare
There was a problem hiding this comment.
Why there are rbac files if controller and rbac config are not set?
There was a problem hiding this comment.
These are autogenerated by kubebuilder when you are ONLY auto generating the CRD.
There was a problem hiding this comment.
Indeed, but seems strange kubebuilder already generated rbac with all verbs when there are no annotations (in the controller) present
There was a problem hiding this comment.
I'd stick to the AtlasThirdPartyIntegration name. Also, see comments from @helderjs
PROJECT
Outdated
| namespaced: true | ||
| domain: mongodb.com | ||
| group: atlas | ||
| kind: AtlasIntegration |
There was a problem hiding this comment.
| kind: AtlasIntegration | |
| kind: AtlasThirdPartyIntegration |
josvazg
force-pushed
the
CLOUDP-305560/add-integrations-crd
branch
from
4bbdbcb to
52fa6f0
Compare
josvazg
force-pushed
the
CLOUDP-305560/add-integrations-crd
branch
from
5a26da1 to
5ff5b72
Compare
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
josvazg
force-pushed
the
CLOUDP-305560/add-integrations-crd
branch
from
0f9f77c to
befb2fd
Compare
| type MicrosoftTeamsIntegration struct { | ||
| // URLSecret is the name of a secret containing the microsoft teams secret URL | ||
| // +kubebuilder:validation:Required | ||
| URLSecret string `json:"urlSecret"` |
There was a problem hiding this comment.
blocking use LocalObjectReference for handling local secret references
| // CredentialsSecret is the name of a secret containing new relic's credentials: | ||
| // account id, license key, read and write tokens | ||
| // +kubebuilder:validation:Required | ||
| CredentialsSecret string `json:"credentialsSecret"` |
There was a problem hiding this comment.
blocking same as above and elsewhere, use LocalObjectReference
Preview for the upcoming Atlas Integration CRD.
All Submissions: