Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement option to override id of replicaSet (see #1650) #1656

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

1st8
Copy link
Contributor

@1st8 1st8 commented Jan 10, 2025

Closes #1650

Summary:

This PR adds a new optional string property in OverrideReplicaSet, which can be used to set the _id of the generated replicaSet config. See #1650 for details of the use case.

I implemented it as a new property in order to not break any existing setups or the default behaviour.

The change has been verified with a test and also by deploying the modified operator to our environment, where it achieves the desired result.

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Contributor

This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review.

@github-actions github-actions bot added the stale label Mar 12, 2025
@1st8
Copy link
Contributor Author

1st8 commented Mar 31, 2025

Still affecting us, the solution in the PR is working nicely.

@github-actions github-actions bot removed the stale label Apr 1, 2025
Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you didn't change existing logic, but added a way to override it if necessary.

PR looks good, thanks for your contribution!

@mircea-cosbuc mircea-cosbuc added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Apr 1, 2025
@MaciejKaras MaciejKaras closed this Apr 1, 2025
@MaciejKaras MaciejKaras reopened this Apr 1, 2025
@MaciejKaras MaciejKaras requested a review from m1kola as a code owner April 1, 2025 09:28
@MaciejKaras MaciejKaras merged commit 0c46290 into mongodb:master Apr 1, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
3 participants