CLOUDP-305848 & CLOUDP-338152 - release on master merges axuillary images #626

nammn · 2025-12-05T15:12:49Z

Summary

replacing ambiguous flags with clearer version selection, removing legacy/manual release variants, and ensuring proper argument passing throughout the pipeline

Pipeline and Release Process Improvements:

Replaces the release_agent task/variant with a new release_on_merge task/variant that runs automatically on every merge, detecting changes to release.json and releasing images based on evg anchors. Manual/manual-patch-only variants for agent and OM 6.0 images are removed.
Updates the agent image build logic to use an explicit agent_version parameter (all, current, or a specific version), removing the previous use of --all-agents and --current-agents flags. Tools version is now required for specific agent builds.

  flowchart TD
      A[Merge to master] --> B[release_on_merge task]
      B --> C[Load config<br/>release.json + .evergreen.yml]

      C --> D[Release via pipeline.py cloud_manager agent]
      C --> E{For each OM version<br/>6.0, 7.0, 8.0}

      E --> F[Release via pipeline.py ops-manager image]
      E --> G[Release via pipeline.py matching agent]

      D & F & G --> H[atomic_pipeline.py skip_if_exists handles duplicates]

related pct pr: https://github.com/10gen/mms/pull/149833

Proof of Work

manual run: Patch - relevant logs

[2025/12/05 16:18:51.394] 2025-12-05 15:18:51,394 - INFO - Found OM 60: 6.0.27
[2025/12/05 16:18:51.394] 2025-12-05 15:18:51,394 - INFO - Found OM 70: 7.0.19
[2025/12/05 16:18:51.394] 2025-12-05 15:18:51,394 - INFO - Found OM 80: 8.0.16
[2025/12/05 16:18:51.394] 2025-12-05 15:18:51,394 - INFO - === Releasing cloud_manager agent: 13.43.0.9995-1 ===
...
...
 All specified image tags already exist. Skipping build.

new tool dry-run

[2025/12/08 10:39:51.814] ============================================================
[2025/12/08 10:39:51.814] RELEASE SUMMARY:
[2025/12/08 10:39:51.814] ============================================================
[2025/12/08 10:39:51.814] Agents:
[2025/12/08 10:39:51.814]   ✓ 13.43.0.9995-1 (cloud_manager)
[2025/12/08 10:39:51.814]   ✓ 12.0.35.7911-1 (OM 6.0.27)
[2025/12/08 10:39:51.814]   ✓ 107.0.19.8805-1 (OM 7.0.19)
[2025/12/08 10:39:51.814]   ✓ 108.0.16.8895-1 (OM 8.0.16)
[2025/12/08 10:39:51.814] Ops Manager:
[2025/12/08 10:39:51.814]   ✓ 6.0.27
[2025/12/08 10:39:51.814]   ✓ 7.0.19
[2025/12/08 10:39:51.814]   ✓ 8.0.16
[2025/12/08 10:39:51.814] Total: 7 releases
[2025/12/08 10:39:51.814] ============================================================

Checklist

Have you linked a jira ticket and/or is the ticket in the title?
Have you checked whether your jira ticket required DOCSP changes?
Have you added changelog file?
- use skip-changelog label if not needed
- refer to Changelog files and Release Notes section in CONTRIBUTING.md for more details

github-actions · 2025-12-05T15:13:45Z

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.1 Release Notes

Bug Fixes

Backed up the agent password in a secret for SCRAM authentication to prevent unnecessary password rotations.
MongoDB Adding missing ownerrefs to ensure proper resource deletion by kubernetes.
Single Cluster Deleting resources created by CRD now only happens on multi-cluster deployments. Single Cluster will solely rely on ownerrefs.
MongoDB, MongoDBOpsManager: Improve validation for featureCompatibilityVersion field in MongoDB and MongoDBOpsManager spec.
The field now enforces proper semantic versioning. Previously, invalid semver values could be accepted,
potentially resulting in incorrect configurations.

nammn · 2025-12-05T15:50:10Z

.evergreen.yml

    display_name: publish_om60_images
    tags: [ "manual_patch" ]
-    allowed_requesters: [ "patch", "github_pr" ]
+    allowed_requesters: [ "patch", "commit" ]


removed github_pr since no need to release them anymore via pct in a PR

.evergreen.yml

nammn · 2025-12-05T16:11:45Z

scripts/release/atomic_pipeline.py

-        logger.info("building current used agents")
+        logger.info("building currently used agents")
    else:
-        agent_versions_to_build = detect_ops_manager_changes()


no need to detect for changes, since we release every commit now

nammn · 2025-12-08T07:58:26Z

scripts/release/tests/test_agents_to_rebuild.py

+)
+
+
+class TestDetectOpsManagerChanges(unittest.TestCase):


file is mostly a rename from scripts/release/tests/test_detect_ops_manager_changes.py and removing most of the tests and adding the last one

nammn · 2025-12-08T08:11:50Z

.evergreen.yml

we decided to not keep om6 publishing code

nammn · 2025-12-08T08:12:10Z

.evergreen.yml

all of this will now be run by merging to master from "release_on_merge.py"

nammn · 2025-12-08T08:12:32Z

.evergreen.yml

-      - name: publish_ops_manager
-      - name: release_agent
-
  - name: publish_om70_images


in theory - we should be able to delete this one, but we can keep it for now, but then it also means removal of release_agent

I don't think we should keep publish_omXX_images variants. Instead we should just document how can we trigger build for particular OM and agent image. I mean some kind of generic evergreen variant that allows you to manually build any image possible and push it to chosen repo. This can be done though in separate PR, but please mention that those variants are not going to be used.

Also is PCT is going to try to add those variants still or you have removed that logic already? Would PCT fail if the relevant variants are missing?

removed, will remove related PCT code and then make a new PR to support singular releases.

…ngodb-kubernetes into agent-release-on-master-merge

scripts/release/release_on_merge.py

scripts/release/release_om_and_agents.py

MaciejKaras

LGTM!

viveksinghggits · 2025-12-10T11:47:56Z

scripts/release/pipeline.py

+                "  --version current                                  (for currently used agents)\n"
+                "  --version <ver> --agent-tools-version <tools_ver>  (for specific agent)"
+            )
+        is_special_version = version in ("all", "current")


nit: should we have const for all and current, it looks like we are using them at a lot of places.

viveksinghggits · 2025-12-10T11:51:07Z

scripts/release/release_om_and_agents.py

+    """
+    Extract OM versions from .evergreen.yml anchors using YAML parsing and semver.
+
+    Returns: {"6.0.27", "7.0.19", "8.0.16"}


I didn't know we had this information already in .evergree.yaml, we recently added similar information in our release.json. https://github.com/mongodb/mongodb-kubernetes/blob/master/release.json#L19

release on master merges axuillary images

87efb02

nammn added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Dec 5, 2025

nammn changed the title ~~release on master merges axuillary images~~ CLOUDP-305848 & CLOUDP-338152 - release on master merges axuillary images Dec 5, 2025

nammn added 2 commits December 5, 2025 16:48

summary at the end

c1f962c

remove publishing

472d3c8

nammn commented Dec 5, 2025

View reviewed changes

remove publishing

803e10e

nammn commented Dec 5, 2025

View reviewed changes

.evergreen.yml Show resolved Hide resolved

nammn added 2 commits December 5, 2025 16:58

remove publishing

5442979

linter

1a48d70

nammn commented Dec 5, 2025

View reviewed changes

nammn added 3 commits December 5, 2025 17:19

remove duplicate

569c6e3

remove not used code

3bf351d

remove not used code

6de3ddd

nammn commented Dec 8, 2025

View reviewed changes

remove all release agent logic

fe2246e

nammn commented Dec 8, 2025

View reviewed changes

.evergreen.yml

Copy link

Collaborator Author

nammn Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we decided to not keep om6 publishing code

MaciejKaras reacted with heart emoji

nammn commented Dec 8, 2025

View reviewed changes

.evergreen.yml

Copy link

Collaborator Author

nammn Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of this will now be run by merging to master from "release_on_merge.py"

nammn commented Dec 8, 2025

View reviewed changes

nammn marked this pull request as ready for review December 8, 2025 08:12

nammn requested a review from a team as a code owner December 8, 2025 08:12

Merge branch 'master' into agent-release-on-master-merge

e716192

nammn requested review from MaciejKaras, anandsyncs and viveksinghggits December 8, 2025 08:12

nammn marked this pull request as draft December 8, 2025 08:32

nammn added 3 commits December 8, 2025 10:00

remove all release agent logic

1a24d0d

Merge branch 'agent-release-on-master-merge' of github.com:mongodb/mo…

73e4943

…ngodb-kubernetes into agent-release-on-master-merge

remove all release agent logic

855593f

linter

e55021e

nammn marked this pull request as ready for review December 8, 2025 10:33

MaciejKaras reviewed Dec 8, 2025

View reviewed changes

scripts/release/release_on_merge.py Outdated Show resolved Hide resolved

MaciejKaras reviewed Dec 8, 2025

View reviewed changes

scripts/release/release_on_merge.py Outdated Show resolved Hide resolved

nammn added 3 commits December 8, 2025 13:41

address feedback

017b91b

consistent raising errors

6ab7714

consistent raising errors

a062e12

MaciejKaras reviewed Dec 8, 2025

View reviewed changes

scripts/release/release_om_and_agents.py Outdated Show resolved Hide resolved

address feedback

0b6d0e5

nammn requested a review from MaciejKaras December 8, 2025 14:12

MaciejKaras approved these changes Dec 8, 2025

View reviewed changes

nammn requested a review from mircea-cosbuc December 8, 2025 18:31

viveksinghggits approved these changes Dec 10, 2025

View reviewed changes

		)


		class TestDetectOpsManagerChanges(unittest.TestCase):

CLOUDP-305848 & CLOUDP-338152 - release on master merges axuillary images #626

Are you sure you want to change the base?

CLOUDP-305848 & CLOUDP-338152 - release on master merges axuillary images #626

Uh oh!

Conversation

nammn commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Proof of Work

Checklist

Uh oh!

github-actions bot commented Dec 5, 2025

MCK 1.6.1 Release Notes

Bug Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nammn Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaciejKaras left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nammn commented Dec 5, 2025 •

edited

Loading

nammn Dec 5, 2025 •

edited

Loading