-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ci(NODE-6951): assume ec2 role explicitly in failing CI tasks #4543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d26b0b
to
86f1aa6
Compare
dariakp
reviewed
May 27, 2025
dariakp
reviewed
May 27, 2025
durran
reviewed
May 27, 2025
durran
reviewed
May 27, 2025
durran
reviewed
May 27, 2025
durran
reviewed
May 27, 2025
baileympearson
commented
May 28, 2025
durran
previously approved these changes
May 28, 2025
dariakp
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR modifies the evergreen config to explicitly assume the AWS role needed to fetch AWS secrets where needed.
As a drive-by improvement, I also refactored some usages of
ec2.assume_role
to use the sharedassume secrets manager rule
function.Is there new documentation needed for these changes?
No.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript