Skip to content

ci(NODE-6951): assume ec2 role explicitly in failing CI tasks #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 27, 2025

Description

What is changing?

This PR modifies the evergreen config to explicitly assume the AWS role needed to fetch AWS secrets where needed.

As a drive-by improvement, I also refactored some usages of ec2.assume_role to use the shared assume secrets manager rule function.

Is there new documentation needed for these changes?

No.

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review May 27, 2025 17:43
@baileympearson baileympearson requested a review from a team as a code owner May 27, 2025 17:43
@dariakp dariakp self-assigned this May 27, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 27, 2025
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 28, 2025
@baileympearson baileympearson requested review from durran and dariakp May 28, 2025 16:47
durran
durran previously approved these changes May 28, 2025
@dariakp dariakp merged commit 25f5bb9 into main May 28, 2025
28 of 29 checks passed
@dariakp dariakp deleted the assume-role-in-ci branch May 28, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants